Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup oppiabot workflow #9669

Merged
merged 5 commits into from
Jun 28, 2020
Merged

Conversation

jameesjohn
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: Sets up oppiabot's GitHub actions check.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Jun 26, 2020

Assigning @kevinlee12 for the first-pass review of this pull request. Thanks!

Copy link
Contributor

@ankita240796 ankita240796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @jameesjohn!

Can you please add screenshots/links of the tests you tried on your repo?

@jameesjohn
Copy link
Contributor Author

Issue labelled check: jameesjohn/comment-on-pr#29
Screenshot (463)

Issue assigned check: jameesjohn/comment-on-pr#35
Screenshot (460)

Copy link
Contributor

@ankita240796 ankita240796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ankita240796 ankita240796 removed their assignment Jun 26, 2020
@jameesjohn
Copy link
Contributor Author

PTAL @kevinlee12
Thanks

@vinitamurthi
Copy link
Contributor

The PR build is in the build queue, and in an attempt to reduce the pressure, we have moved the lint and backend tests to Github Actions. For quicker test results, can @jameesjohn please merge from develop and push? We have cancelled your build so that it will run quicker when you merge and push

@jameesjohn
Copy link
Contributor Author

jameesjohn commented Jun 26, 2020

I just did that @vinitamurthi (after getting Sean's mail).

@vinitamurthi
Copy link
Contributor

Oh I think you did it a bit too soon and the code change we wanted in your branch wasn't available :) Now that you have merged again you are good to go (notice that backend and lint tests are not in circle ci anymore)

@jameesjohn
Copy link
Contributor Author

Yup
Thanks

Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12 kevinlee12 removed their assignment Jun 26, 2020
@jameesjohn
Copy link
Contributor Author

I'm not sure why frontend tests should be failing here

@kevinlee12
Copy link
Contributor

@jameesjohn can you merge from develop once more?

@jameesjohn
Copy link
Contributor Author

It's already up to date @kevinlee12
Screenshot (465)

@kevinlee12
Copy link
Contributor

I’ve restarted it, but can you run it locally? If it fails, talk to Nithesh or any one of the core maintainers.

@kevinlee12
Copy link
Contributor

I don't see this impacting the results of other tests, so @ankita240796, you might want to talk with Sean to see if we should just merge this PR.

@ankita240796 ankita240796 merged commit 39aca85 into oppia:develop Jun 28, 2020
shavavo pushed a commit to shavavo/oppia that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants