-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup oppiabot workflow #9669
Setup oppiabot workflow #9669
Conversation
Assigning @kevinlee12 for the first-pass review of this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @jameesjohn!
Can you please add screenshots/links of the tests you tried on your repo?
Issue labelled check: jameesjohn/comment-on-pr#29 Issue assigned check: jameesjohn/comment-on-pr#35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PTAL @kevinlee12 |
The PR build is in the build queue, and in an attempt to reduce the pressure, we have moved the lint and backend tests to Github Actions. For quicker test results, can @jameesjohn please merge from develop and push? We have cancelled your build so that it will run quicker when you merge and push |
I just did that @vinitamurthi (after getting Sean's mail). |
Oh I think you did it a bit too soon and the code change we wanted in your branch wasn't available :) Now that you have merged again you are good to go (notice that backend and lint tests are not in circle ci anymore) |
Yup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I'm not sure why frontend tests should be failing here |
@jameesjohn can you merge from develop once more? |
It's already up to date @kevinlee12 |
I’ve restarted it, but can you run it locally? If it fails, talk to Nithesh or any one of the core maintainers. |
I don't see this impacting the results of other tests, so @ankita240796, you might want to talk with Sean to see if we should just merge this PR. |
Overview
Essential Checklist
PR Pointers