fix(optic): don't loop forever when running from /
#2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnmeyer
changed the title
notnmeyer
changed the title
/
niclim
reviewed
Feb 26, 2024
niclim
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍗 Description
What does this PR do? Anything folks should know?
i noticed what i thought was an issue with our docker image, where any invocation of optic would hang without output and require a
kill -9to stop. after some stracing and validating where it first sprung up i narrowed it down to the seemingly innocuous way we walk the file tree to find a config.when
$PWDis/the walk enters an infinite loop. this most noticeable in the image because we leave itsWORKDIRset at the root,/. you can however replicate this on macOS as well with,just be ready to grab the pid so you can kill it :)
📚 References
Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.
👹 QA
How can other humans verify that this PR is correct?