Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focus] Non-case class getters #1034

Open
julien-truffaut opened this issue Feb 8, 2021 · 0 comments
Open

[Focus] Non-case class getters #1034

julien-truffaut opened this issue Feb 8, 2021 · 0 comments
Labels
After 3.0 Wait for user feedback from the 3.0 release
Milestone

Comments

@julien-truffaut
Copy link
Member

There's no reason not to allow plain old getter methods on non-case classes, generating a Getter. This is something that a user might reasonably guess is supported, and it seems unreasonably to make them bust out the Optics Family documentation to do it.

eg Focus[String](_.length) // Getter[String,Int]

Original issue: optics-dev/Monocly#39

@julien-truffaut julien-truffaut added the 3.x Next major version label Feb 8, 2021
@kenbot kenbot added After 3.0 Wait for user feedback from the 3.0 release and removed 3.x Next major version labels Feb 21, 2021
yilinwei added a commit to yilinwei/Monocle that referenced this issue Dec 21, 2023
@yilinwei yilinwei added this to the 3.3 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
After 3.0 Wait for user feedback from the 3.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants