- Updated Java sdk version from 1.8 to 2.0.0-beta2 and removed Live variables #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* - Updated Java sdk version from 1.8 to 2.0.0-beta2 - Removed getVariableString getVariableBoolean getVariableInteger getVariableDouble -Remove track with revenue as a parameter. Pass the revenue value as an event tag instead track(String, String, long) track(String, String, Map<String, String>, long) * added multidex enabled support * make common Constant of $multidex_ver to use in all gradle
* Excluded group: 'com.google.code.findbugs' from dependency of com.optimizely.ab:core-api removed Multidex enabling from sdk and test app
mnoman09
changed the title
|
@thomaszurkan-optimizely we are investigating why test_api_version_25 getting failed. I will let you know once its fixed. It's showing out of memory but need to fix it. |
wangjoshuah
reviewed
Jan 4, 2018
| @@ -62,7 +62,9 @@ dependencies { | |||
| compile project(':datafile-handler') | |||
| compile project(':event-handler') | |||
| compile project(':user-profile') | |||
| compile "com.optimizely.ab:core-api:$java_core_ver" | |||
| compile ("com.optimizely.ab:core-api:$java_core_ver") { | |||
| exclude group: 'com.google.code.findbugs' | |||
There was a problem hiding this comment.
why are we excluding the find bugs scan?
There was a problem hiding this comment.
There was a problem hiding this comment.
thanks. we should move off of findbugs anyways since they are not currently being supported
@mnoman09 what other static code linters should we use?
wangjoshuah
suggested changes
Jan 4, 2018
|
|
||
| // This app is built against a real Optimizely project with real experiments set. Automated | ||
| // This app is built against a real Optimizely project with real experiments set. Automated |
mnoman09
changed the title
wangjoshuah
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getVariableString
getVariableBoolean
getVariableInteger
getVariableDouble
-Remove track with revenue as a parameter. Pass the revenue value as an event tag instead
track(String, String, long)
track(String, String, Map<String, String>, long)
added multidex enabled support
make common Constant of $multidex_ver to use in all gradle