Josh/wrapper #2
Merged
Josh/wrapper #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ android { | |||
| dependencies { | |||
| compile project(':shared') | |||
|
|
|||
| provided "com.optimizely.ab:core-api:$java_core_ver" | |||
| compile "com.optimizely.ab:core-api:$java_core_ver" | |||
There was a problem hiding this comment.
I thought project watcher doesn't need the core
|
LGTM |
elliotykim
pushed a commit
that referenced
this pull request
Apr 25, 2017
Summary: Fix for crash #2 Test Plan: automated Reviewers: #oasis_team_review, mike.ng JIRA Issues: OASIS-1235 Differential Revision: https://phabricator.optimizely.com/D15711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up a 'wrapper' module on top of SST java and implemented in the test app.
As usual, names are subject to change.
I think this is what you wanted @mikeng13