Skip to content

check for alpha and call it a sdk key if it has any alpha characters. #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

thomaszurkan-optimizely
Copy link
Contributor

No description provided.

@@ -20,9 +20,11 @@
import android.content.Context;
import android.content.SharedPreferences;
import android.os.Build;
import android.provider.ContactsContract;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this import still needed?

optimizelyManager = builder.withEventDispatchInterval(60L * 10L)
.withDatafileDownloadInterval(60L * 10L)
.withSDKKey("6hmwpgZcRFp36wH5QLK8Sb")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the indentation is different between these three lines

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 7422543 into master Jul 18, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the fix/background/sdkkey branch July 18, 2018 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants