Skip to content

Bump for 2.0.0-beta6 release. #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Bump for 2.0.0-beta6 release. #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02f98fd
Bump for 2.0.0-beta6 release.
Aug 1, 2018
e246ba7
Fix breaking tests from updating to Java 2.1.2.
Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Optimizely Android X SDK Changelog

## 2.0.0-beta6
August 1st, 2018

### Bug Fixes
* Bump to Java SDK (2.1.2)[https://github.com/optimizely/java-sdk/releases/tag/2.1.2] which improves performance of API calls from.
* Bring back async init without the datafile. (#211)

## 2.0.0-beta5
July 23, 2018

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ ext {
build_tools_version = "27.0.0"
min_sdk_version = 14
target_sdk_version = 26
java_core_ver = "2.1.1"
java_core_ver = "2.1.2"
android_logger_ver = "1.3.6"
support_annotations_ver = "24.2.1"
junit_ver = "4.12"
Expand Down
8 changes: 4 additions & 4 deletions ...src/androidTest/java/com/optimizely/ab/android/event_handler/DefaultEventHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import android.util.Pair;

import com.optimizely.ab.event.LogEvent;
import com.optimizely.ab.event.internal.payload.EventBatch;

import org.junit.After;
import org.junit.Before;
Expand Down Expand Up @@ -54,7 +55,6 @@ public class DefaultEventHandlerTest {

private DefaultEventHandler eventHandler;
private String url = "http://www.foo.com";
private String requestBody = "key1=val1&key2=val2&key3=val3";

@Before
public void setupEventHandler() {
Expand All @@ -68,20 +68,20 @@ public void setupEventHandler() {

@Test
public void dispatchEventSuccess() throws MalformedURLException {
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, url, new HashMap<String, String>(), requestBody));
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, url, new HashMap<String, String>(), new EventBatch()));
//verify(context).startService(any(Intent.class));
verify(logger).info("Sent url {} to the event handler service", "http://www.foo.com");
}

@Test
public void dispatchEmptyUrlString() {
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, "", new HashMap<String, String>(), requestBody));
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, "", new HashMap<String, String>(), new EventBatch()));
verify(logger).error("Event dispatcher received an empty url");
}

@Test
public void dispatchEmptyParams() {
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, url, new HashMap<String, String>(), requestBody));
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, url, new HashMap<String, String>(), new EventBatch()));
//verify(context).startService(any(Intent.class));
verify(logger).info("Sent url {} to the event handler service", "http://www.foo.com");
}
Expand Down
8 changes: 4 additions & 4 deletions ...andler/src/test/java/com/optimizely/ab/android/event_handler/DefaultEventHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import android.content.Intent;

import com.optimizely.ab.event.LogEvent;
import com.optimizely.ab.event.internal.payload.EventBatch;

import org.junit.Before;
import org.junit.Test;
Expand All @@ -45,7 +46,6 @@ public class DefaultEventHandlerTest {

private DefaultEventHandler eventHandler;
private String url = "http://www.foo.com";
private String requestBody = "key1=val1&key2=val2&key3=val3";

@Before
public void setupEventHandler() {
Expand All @@ -57,20 +57,20 @@ public void setupEventHandler() {

@Test
public void dispatchEventSuccess() throws MalformedURLException {
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, url, new HashMap<String, String>(), requestBody));
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, url, new HashMap<String, String>(), new EventBatch()));
verify(context).startService(any(Intent.class));
verify(logger).info("Sent url {} to the event handler service", "http://www.foo.com");
}

@Test
public void dispatchEmptyUrlString() {
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, "", new HashMap<String, String>(), requestBody));
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, "", new HashMap<String, String>(), new EventBatch()));
verify(logger).error("Event dispatcher received an empty url");
}

@Test
public void dispatchEmptyParams() {
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, url, new HashMap<String, String>(), requestBody));
eventHandler.dispatchEvent(new LogEvent(LogEvent.RequestMethod.POST, url, new HashMap<String, String>(), new EventBatch()));
verify(context).startService(any(Intent.class));
verify(logger).info("Sent url {} to the event handler service", "http://www.foo.com");
}
Expand Down