update credits #219
Merged
update credits #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaszurkan-optimizely
requested review from
mikeproeng37 and
spencerwilson-optimizely
mikeproeng37
suggested changes
Aug 16, 2018
README.md
Outdated
| @@ -88,3 +88,18 @@ For example, to release version 0.1.2 you need to pull devel, checkout master, p | |||
| ## Contributing | |||
| Please see [CONTRIBUTING](CONTRIBUTING.md). | |||
|
|
|||
| ### Credits | |||
|
|
|||
| First-party code is copyright Optimizely, Inc. and contributors, licensed under Apache 2.0. | |||
There was a problem hiding this comment.
Can you include the location of the first party code here so we can be explicitt about it
README.md
Outdated
|
|
||
| This software incorporates code from the following open source projects: | ||
|
|
||
| **Otimizely.ab:core-api** [https://github.com/optimizely/java-sdk](https://github.com/optimizely/java-sdk) |
There was a problem hiding this comment.
nit: typo "Otimizely"
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.