fix: support datafile download and events upload for API-16 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimizely-codereview-bot
added
🤖 20 hrs
🤖 24 hrs
and removed
🤖 12 hrs
🤖 16 hrs
🤖 20 hrs
labels
mnoman09
suggested changes
Jun 2, 2021
| } | ||
|
|
||
| private Socket enableTLSOnSocket(Socket socket) { | ||
| if(socket != null && (socket instanceof SSLSocket)) { |
There was a problem hiding this comment.
socket != null is not required before instanceof check. So I think we can remove it
| @@ -0,0 +1,72 @@ | |||
| package com.optimizely.ab.android.shared; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Android devices with API-19 and lower is set by default to use SSL lower than the our server requirements (TLS1.2+).
With this fix, those low-API devices will be set to use TLS1.2 for both datafile download and event upload.
Test plan
Issues