Skip to content

fix(DatafileHandler): unschedule background polling worker when interval is not set #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

fix(DatafileHandler): unschedule background polling worker when interval is not set #397

merged 1 commit into from
Jan 5, 2022

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Dec 21, 2021 •
edited
Loading

Summary

  • This fixes the bug that a polling worker scheduled before is not disabled when Optimizely is initialized again with polling disabled.
  • When Optimizely is initialized, stop the previous worker and then restart it again only when polling is enabled.

Test plan

  • Unit tests

Issues

  • OASIS-8118

@jaeopt jaeopt requested a review from a team as a code owner December 21, 2021 23:37
@jaeopt jaeopt removed their assignment Dec 22, 2021
mnoman09
mnoman09 approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 708ecbf into master Jan 5, 2022
@jaeopt jaeopt deleted the jae/oasis-8118 branch January 5, 2022 17:08
@jaeopt jaeopt mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnoman09 mnoman09 mnoman09 approved these changes

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @mnoman09 @optimizely-codereview-bot