Josh/persistent buckter #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| events.add(new Pair<>(itemId, new Event(new URL(url)))); | ||
| } catch (MalformedURLException e) { | ||
| logger.error("Retreived a malformed event from storage", e); |
|
Looks good, just one question on whether saving to cache could be a block call |
|
We should be doing file I/O off the main thread. Let me think about how this should work. |
added 7 commits
August 15, 2016 17:35
| try { | ||
| userExperimentRecord = cache.load(getFileName()); | ||
| } catch (FileNotFoundException e) { | ||
| logger.info("No persistent bucketer cache found"); |
There was a problem hiding this comment.
user experiment record
|
LGTM, just two small things to address |
…ound via parcelable
Josh/tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
ProjectWatcherintroduced in this PR in SST Java. It uses the same file cache pattern used by event handler and project watcher.I just build 0.1.69 of SST Java locally and hooked up manually to my android repo. When we launch this will be built from maven. This is useful until the next version of SST Java is published.