Skip to content

Remove JsonNet.PrivateSettersContractResolvers dependency. #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

mfahadahmed
Copy link
Contributor

@mfahadahmed mfahadahmed commented Oct 19, 2018

we removed this dependency as it is not longer being used in Optimizely Project. It was also added as developmentDependency in nuspec which is not really needed.
Removed developmentdepency from demoapp and from OptimizelySDK package.config file and also from nuspec.

@msohailhussain
Copy link
Contributor

#78

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit d648b85 into master Oct 26, 2018
@mfahadahmed mfahadahmed deleted the fahad/remove-contractresolver branch January 11, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants