Skip to content

chore(contrib): Add PR template and commit message guidelines. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2018
Merged

chore(contrib): Add PR template and commit message guidelines. #111

merged 2 commits into from
Nov 9, 2018

Conversation

mfahadahmed
Copy link
Contributor

@mfahadahmed mfahadahmed commented Nov 6, 2018 •
edited
Loading

Summary

  • Adds commit message guidelines in CONTRIBUTING.md
  • Adds PR template for Github PRs

mikeproeng37
mikeproeng37 suggested changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the bit about forking the repo.

mikeproeng37
mikeproeng37 approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mikeproeng37 mikeproeng37 merged commit 5b0039b into master Nov 9, 2018
@mfahadahmed mfahadahmed deleted the fahad/contributing-guidelines branch January 11, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfahadahmed @mikeproeng37