feat(api): Decision Notification Listener for activate and getVariation APIs. #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfahadahmed
changed the title
| <Compile Include="..\OptimizelySDK\Utils\ExperimentUtils.cs" /> | ||
| <Compile Include="..\OptimizelySDK\Utils\ConditionParser.cs" /> | ||
| <Compile Include="..\OptimizelySDK\Utils\AttributeMatchTypes.cs" /> | ||
| <Compile Include="..\OptimizelySDK\Utils\ControlAttributes.cs" /> |
There was a problem hiding this comment.
Please indent.
Why all these files are included in .netstandard16? Not in other Projects?
mikeproeng37
approved these changes
Apr 3, 2019
| { "variationKey", variation?.Key }, | ||
| }; | ||
|
|
||
| NotificationCenter.SendNotifications(NotificationCenter.NotificationType.Decision, DecisionInfoTypes.EXPERIMENT, userId, |
There was a problem hiding this comment.
nit: maybe initialize userAttributes as an empty UserAttributes object before calling sendNotification
| @@ -59,6 +60,15 @@ public enum NotificationType | |||
| public delegate void TrackCallback(string eventKey, string userId, UserAttributes userAttributes, EventTags eventTags, | |||
| LogEvent logEvent); | |||
|
|
|||
| /// <summary> | |||
| /// Delegate for decision notifcations. | |||
There was a problem hiding this comment.
nit: typo notifications
|
@mfahadahmed @msohailhussain just minor feedback from Mike. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan