feat(api): Decision Notification Listener for IsFeatureEnabled and GetEnabledFeatures APIs. #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfahadahmed
changed the title
…ener-feature-enabled
…ener-feature-enabled # Conflicts: # OptimizelySDK.Tests/ProjectConfigTest.cs # OptimizelySDK.Tests/TestData.json
aliabbasrizvi
suggested changes
Apr 4, 2019
OptimizelySDK/Optimizely.cs
Outdated
| @@ -645,5 +669,10 @@ private bool ValidateStringInputs(Dictionary<string, string> inputs) | |||
|
|
|||
| return isValid; | |||
| } | |||
|
|
|||
| private bool IsValidDecision(FeatureDecision decision) | |||
There was a problem hiding this comment.
What is this validity check about? Also, I feel it belongs on the FeatureDecision class and not like this.
There was a problem hiding this comment.
Perhaps call it IsExperimentDecision?
There was a problem hiding this comment.
This check validates decision object. But I misunderstood that DecisionService.GetVariationForFeature() can return null.
I removed this function as the above method can't return null and checking decision.Variation is enough for validating decision object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan