Skip to content

fix(locale): GetFeatureVariableDouble was not returning expected value for FR culture #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2020
Merged

fix(locale): GetFeatureVariableDouble was not returning expected value for FR culture #209

merged 3 commits into from
Jan 30, 2020

Conversation

msohailhussain
Copy link
Contributor

Summary

  • GetFeatureVariableDouble was returning 0 for FR culture. Fixed this issue by returning Invariant culture.

Test plan

  • Added unit test to set FR culture and asserted expected value.
  • Also added unit test for other feature variable APIs.
  • FSC should pass all tests.

Issues

@msohailhussain msohailhussain requested a review from a team as a code owner January 24, 2020 18:26
mikeproeng37
mikeproeng37 approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding tests

@mikeproeng37 mikeproeng37 merged commit 32e3f29 into master Jan 30, 2020
@msohailhussain msohailhussain deleted the sohail/variantculture branch April 29, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@msohailhussain msohailhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msohailhussain @mikeproeng37