Skip to content

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Jul 17, 2020

Summary

  • Added datafileAccessToken in ClientConfigHandler to read it from App.config.

Test plan

Added unit tests

README.md Outdated
@@ -205,6 +206,10 @@ This option enables user to provide a custom URL format to fetch the datafile.

This option is used to specify whether to start the config manager on initialization or not. If no value is provided, by default it is true and will start polling datafile from remote immediately.

##### Datafile access token

This option is used to provide token for authenticated datafile access.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit.... provide token for datafile belonging to a secure environment.

Copy link

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 11745a4 into master Jul 23, 2020
@mikeproeng37 mikeproeng37 deleted the mnoman/accessTkn branch July 23, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants