Skip to content

feat: added enabled field in metadata. #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2020
Merged

feat: added enabled field in metadata. #249

merged 1 commit into from
Nov 13, 2020

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Nov 9, 2020 •
edited
Loading

Summary

  • While sending impression events, metadata should have enabled field as well.

Test plan

@msohailhussain msohailhussain changed the title added enabled field in metadata. feat: added enabled field in metadata. Nov 10, 2020
@msohailhussain msohailhussain marked this pull request as ready for review November 10, 2020 00:03
@msohailhussain msohailhussain requested a review from a team as a code owner November 10, 2020 00:03
@msohailhussain msohailhussain removed their assignment Nov 10, 2020
@pawels-optimizely pawels-optimizely merged commit 009e68c into master Nov 13, 2020
@pawels-optimizely pawels-optimizely deleted the sohail/fd_patch branch November 13, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@msohailhussain msohailhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msohailhussain @pawels-optimizely @optimizely-codereview-bot