snk now only mentioned by pack.ps1 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangjoshuah
reviewed
Nov 9, 2017
| @@ -12,8 +12,6 @@ | |||
| <TargetFrameworkVersion>v3.5</TargetFrameworkVersion> | |||
| <FileAlignment>512</FileAlignment> | |||
| <ReleaseVersion>1.2.1</ReleaseVersion> | |||
| <SignAssembly>true</SignAssembly> | |||
There was a problem hiding this comment.
No, we are still signing. The pack.ps1 does the sn.exe signing. There seem to be about 4 different ways to do sn.exe signing documented at various MS URL's, but the most reliable approach for us has been sn.exe in pack.ps1 . We're keeping this. The other 2 ways we're dropping were redundancies which, unfortunately, do interfere with our E2E testing.
wangjoshuah
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P.R. leaves task of calling sn.exe and strongnaming entirely in pack.ps1's hands.
There were some new issues with the redundant and not wholely effective calls to sn.exe
in VS 2017 custom "After Build" commands. One issue is these cause "Build FAILED"s
in our E2E tests which rely on '/bin/sh -c dotnet build --configuration Release'
instead of msbuild.
The E2E regression goes away in this P.R.