Skip to content

[FSSDK-9039] Fix e2e ODP event response #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

As a bug bash engineer, I would like ODP events being sent from the C# SDK to not return an HTTP Status 400.

Test plan

  • Existing unit and integration test should pass
  • Bug bash engineer's test app should pass end-to-end testing

Issues

  • FSSDK-9039

@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review April 7, 2023 12:55
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner April 7, 2023 12:55
@mikechu-optimizely mikechu-optimizely requested review from andrewleap-optimizely and removed request for a team April 7, 2023 12:56
Copy link
Contributor Author

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developer PR review completed.

Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@pulak-opti pulak-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikechu-optimizely mikechu-optimizely merged commit 7621f90 into master Apr 7, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/bug-400-ODP-event branch April 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants