Skip to content

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

Support a new format for ODP InvalidIdentifierException (when SDK fetches segments with a non-registered userId).

       "extensions": {
            "code": "INVALID_IDENTIFIER_EXCEPTION",
            "classification": "DataFetchingException"
       }

Test plan

  • Added unit tests to cover the new response format.
  • Existing unit tests should pass
  • FSC should continue to pass

Issues

  • FSSDK-9128

@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review April 24, 2023 21:05
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner April 24, 2023 21:05
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a logic change to provide proper error message for INVALID_IDENTIFIER_EXCEPTION. Can you check again?

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The error "code" is optional. Can you check if we have a test case without code?

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely removed the request for review from andrewleap-optimizely April 25, 2023 16:31
@mikechu-optimizely mikechu-optimizely merged commit 9062dd8 into master Apr 25, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/invalid-identifier branch April 25, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants