Skip to content

(chore): update changelog for beta release #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2019

Conversation

thomaszurkan-optimizely
Copy link
Contributor

No description provided.

CHANGELOG.MD Outdated
@@ -4,9 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [1.0.0-beta1] - September 27th, 2019
Changes that have landed but are not yet released.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should keep the Unreleased section and create a new heading for this release

CHANGELOG.MD Outdated
@@ -4,9 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [1.0.0-beta1] - September 27th, 2019
Changes that have landed but are not yet released.
- Support for running full feature tests with the SDK.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed as it was already added last release

CHANGELOG.MD Outdated
Changes that have landed but are not yet released.
- Support for running full feature tests with the SDK.
- Support for optional parameters via optional configuration self referential functions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a subheading here for New Features.

We've also added decision listeners and project config update listeners as new features since last release

Also we have a breaking change:

  • This method OptimizelyFactory.ClientWithOptions() has been removed in favor of OptimizelyFactory.Client(clientOptions ...OptionFunc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! thanks!

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit bacefab into master Sep 27, 2019
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the prepareRelease1-beta branch September 27, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants