Skip to content

fix(1.8): go 1.8 fix #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2020
Merged

fix(1.8): go 1.8 fix #237

merged 3 commits into from
Feb 10, 2020

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Feb 3, 2020 •
edited
Loading

Summary

  • go 1.8 was unable to run unit tests because of stretcher/testify introduced new methods in the interface which we are not implementing.
  • checkedout specific branch which doesn't have that new method in the interface. Here's the commit caused issue.
    stretchr/testify@ea72eb9

Testplan

  • All unit tests and FSC are running fine.

@msohailhussain msohailhussain marked this pull request as ready for review February 4, 2020 00:35
@msohailhussain msohailhussain requested a review from a team as a code owner February 4, 2020 00:35
@msohailhussain msohailhussain changed the title go 1.8 fix fix(1.8): go 1.8 fix Feb 4, 2020
@pawels-optimizely pawels-optimizely merged commit e42d75c into master Feb 10, 2020
@pawels-optimizely pawels-optimizely deleted the sohail/fixgo18 branch February 10, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

1 more reviewer

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msohailhussain @pawels-optimizely @optimizely-codereview-bot