Skip to content

ci: Run source clear only on cron and before linting and tests #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Jul 29, 2020

Summary

Stages run sequentially on Travis. If a stage fails, all the following stages are not executed. We execute source clear only on cron, and if due to any reason unit or integration tests fail, the source clear is not executed. Hence, moving source clear stage before tests.

Test plan

All unit tests must be passed.
FSC must be passed.

@oakbani oakbani requested a review from a team as a code owner July 29, 2020 11:11
@oakbani oakbani removed their assignment Jul 29, 2020
@oakbani oakbani changed the title ci: Run source clear before linting and tests ci: Run source clearonly on cron and before linting and tests Jul 29, 2020
@oakbani oakbani changed the title ci: Run source clearonly on cron and before linting and tests ci: Run source clear only on cron and before linting and tests Jul 29, 2020
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 9010b01 into master Jul 31, 2020
@mikeproeng37 mikeproeng37 deleted the oakbani-patch-1 branch July 31, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants