[FSSDK-9360] fix(utils): logging correct error message in HTTP requests #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpfeifer
changed the title
seanpfeifer
changed the title
|
The Travis CI $ mkdir $HOME/travisci-tools && pushd $HOME/travisci-tools && git init && git pull https://$CI_USER_TOKEN@github.com/optimizely/travisci-tools.git && popd
~/travisci-tools ~/build/optimizely/go-sdk
hint: ... (omitted for log brevity)
Initialized empty Git repository in /home/travis/travisci-tools/.git/
remote: Repository not found.
fatal: Authentication failed for 'https://github.com/optimizely/travisci-tools.git/'
The command "mkdir $HOME/travisci-tools && pushd $HOME/travisci-tools && git init && git pull https://$CI_USER_TOKEN@github.com/optimizely/travisci-tools.git && popd" failed and exited with 1 during .From these logs it looks like something may be missing / misconfigured with Travis or the |
|
Hi @seanpfeifer, thanks for opening this PR! Can you please update your branch with master? |
|
Merged and tested. |
pulak-opti
suggested changes
Apr 19, 2023
pulak-opti
approved these changes
Apr 20, 2023
yasirfolio3
approved these changes
Apr 20, 2023
Updated! |
|
Hi, the fix is merged here. #374 Thank you for your contribution! |
pulak-opti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently set to always log a
nilerror using the unset return parametere, instead of the actual error that gets assigned todoErr.This change will allow users to see the HTTP error in these messages.
Submissions info