feat(decision): Adds composite experiment bucketer that targets and buckets #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
requested review from
aliabbasrizvi,
pawels-optimizely and
thomaszurkan-optimizely
aliabbasrizvi
approved these changes
Jul 8, 2019
| "github.com/twmb/murmur3" | ||
| ) | ||
|
|
||
| var logger = logging.GetLogger("ExperimentBucketer") | ||
| var maxHashValue = float32(math.Pow(2, 32)) | ||
|
|
||
| // DefaultHashSeed is the hash seed to use for murmurhash | ||
| const DefaultHashSeed = 1 | ||
| const maxTrafficValue = 10000 |
There was a problem hiding this comment.
nit. Technically this is maxBucketValue
| "github.com/twmb/murmur3" | ||
| ) | ||
|
|
||
| var logger = logging.GetLogger("ExperimentBucketer") | ||
| var maxHashValue = float32(math.Pow(2, 32)) | ||
|
|
||
| // DefaultHashSeed is the hash seed to use for murmurhash | ||
| const DefaultHashSeed = 1 |
There was a problem hiding this comment.
nit. Curious about the syntax here. This name begins with capital letter and the next name begins with small letter. Are we adhering to the standards described here: https://golang.org/doc/effective_go.html#names?
There was a problem hiding this comment.
Yeah, capitalized means we are making it an exported value in this package. I made it public because we reference it from the experiment_bucketer_service which uses it to create an instance of the MurmurhashBucketer. We could just not take in the hash seed in that factory method and default it to this constant. I have no strong opinions about it.
| bucketValue := b.generateBucketValue(bucketKey) | ||
| // logger.Info() |
mjc1283
reviewed
Jul 8, 2019
mjc1283
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MurmurhashBucketerTests