restructuring code to fit audience condition into existing code. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
suggested changes
Jul 15, 2019
| @@ -26,14 +26,15 @@ type Audience struct { | |||
| // Experiment represents an Experiment object from the Optimizely datafile | |||
| type Experiment struct { | |||
| // @TODO(mng): include audienceConditions | |||
There was a problem hiding this comment.
Can remove this comment from me 😄
| switch v := node.Item.(type) { | ||
| case entities.Condition: | ||
| evaluator := CustomAttributeConditionEvaluator{} | ||
| result, err = evaluator.Evaluate(node.Item, condTreeParams) |
There was a problem hiding this comment.
If we are already special casing here, why not make the evaluator.Evaluate( ) take in the typed Condition instead of an interface. And the same for the AudienceConditionEvaluator since we already know that the item we are evaluating is a string?
| if !evalResult { | ||
| // user not targeted for experiment, return an empty variation | ||
| experimentDecision.DecisionMade = true | ||
| experimentDecision.Variation = entities.Variation{} |
There was a problem hiding this comment.
This line isn't needed right since it'll just be the default zero-value Variation
# Conflicts: # optimizely/decision/experiment_targeting_service.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.