[go-sdk] Post bug bash optimizations - hide retryConfig #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove RetryConfig field from public cmab.Config struct - Change DefaultMaxRetries from 3 to 1 for conservative first release - Use hardcoded internal retry config in ExperimentCmabService - Create client-level CmabConfig type for stable public API - Update all tests to use new configuration approach This keeps retry functionality internal while preventing API exposure that might need to change in future releases.
raju-opti
requested changes
Sep 26, 2025
Keep existing code structure instead of hardcoding retry config. Since RetryConfig is no longer in public API, always use defaults but maintain the same if/else structure for consistency.
|
Merging with FSC failing, because FSC 3 test failing are unrelated. A known issue with tests for regions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead, we can add a separate type in the same file. We can keep the exposed type stable while being able to change the internal *cmab.config if needed.
Jira ticket:
https://jira.sso.episerver.net/browse/FSSDK-11877