Skip to content

feat(config): Parse and map rollouts from the datafile. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2019
Merged

feat(config): Parse and map rollouts from the datafile. #44

merged 3 commits into from
Jul 23, 2019

Conversation

mikeproeng37
Copy link
Contributor

@mikeproeng37 mikeproeng37 commented Jul 22, 2019 •
edited
Loading

Summary

  • Parses rollouts from the datafile
  • Creates Rollout entity in the config
  • Removes references to variables as they won't be implemented yet for Rollouts

Tests

  • Unit tests

pawels-optimizely
pawels-optimizely approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 540f3f3 into go-alpha Jul 23, 2019
@mikeproeng37 mikeproeng37 deleted the mng/map-rollouts branch August 28, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeproeng37 @aliabbasrizvi @pawels-optimizely