Adjusting config manager to support a Sync method #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliabbasrizvi
commented
Sep 11, 2019
aliabbasrizvi
commented
Sep 11, 2019
optimizely/config/polling_manager.go
Outdated
| t := time.NewTicker(cm.pollingInterval) | ||
| for { | ||
| select { | ||
| case <-t.C: | ||
| update() | ||
| cm.Sync([]byte{}) |
There was a problem hiding this comment.
keep private, sync instead of Sync
optimizely/config/polling_manager.go
Outdated
| projectConfig, err := datafileprojectconfig.NewDatafileProjectConfig(payload) | ||
| if err != nil { | ||
| cmLogger.Error("failed to create project config", err) | ||
| func (cm *PollingProjectConfigManager) Sync(datafile []byte) { |
There was a problem hiding this comment.
please add a comment, otherwise linters will complain
comment has to be like // SyncConfig .......
pawels-optimizely
approved these changes
Sep 11, 2019
mikeproeng37
suggested changes
Sep 11, 2019
| func (cm *PollingProjectConfigManager) SyncConfig(datafile []byte) { | ||
| var e error | ||
| var code int | ||
| if len(datafile) == 0 { |
There was a problem hiding this comment.
Can we do a nil check and pass in nil from the ticker sync call below? It is more accurate to treat it as nil than an empty byte array
There was a problem hiding this comment.
we will be able to pass both, so we need to check for len of datafile when it's not nil, and also for nil itself
There was a problem hiding this comment.
I am going by @pawels-optimizely 's comment and leaving this as is.
…ivate-->start and some other terms
aliabbasrizvi
force-pushed
the
ali/modify_config_manager
branch
from
2fbe431 to
a3ac5b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing this method will allow some advanced use cases like requesting datafile be updated on demand.