Skip to content

Add support for v2 endpoint #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 19, 2016
Merged

Add support for v2 endpoint #14

merged 19 commits into from
Sep 19, 2016

Conversation

vraja2
Copy link
Contributor

@vraja2 vraja2 commented Sep 19, 2016 •
edited
Loading

Vignesh Raja added 18 commits September 15, 2016 20:28
Add objects to aid with payload serialization for v2 impression and c…
eacb2ba 
…onversion events
Add serializers using supported JSON libraries
3990227
Rename packages/files and fix nits
12ff92d
Add layerId to Experiment and modify tests to accommodate this change
45c9c1e
Add EventBuilderV2
7057b0a
Conditionally use V1 or V2 EventBuilders based on datafile version an…
c1178d7 
…d fix some tests
Add logic to dispatch POST or GET requests in the Async event dispatcher
d129567
Fix typo
59f9731
Use payload package instead of payloadV2
bd9cb35
Modify JSON parsers to set layerId to null if one doesn't exist
879f154
Update test JSON datafiles and add parser tests
f543d11
Adjust tests to use different versions of test datafile
04a4e2f
Change variable name from decisionTicket to decision
2738d53
Fix nit and add clientEngine/clientVersion to impression and conversi…
309522d 
…on events
Fix findbugs issues
6d01aeb
Set shouldIndex to true and fix nits
7ebe083
Add support for attributes key in datafile
f6eaafe 
* Add support for attributes key in datafile, while maintaining backwards compatibility for dimensions
Bump version
cab3bbf
@aliabbasrizvi
Copy link
Contributor

Remember to update CHANGELOG. Otherwise LGTM.

@haleybash-optimizely
Copy link

lgtm now that CHANGELOG has been updated

@vraja2 vraja2 merged commit 480d1e6 into master Sep 19, 2016
@vraja2 vraja2 deleted the v2-support branch September 19, 2016 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vraja2 @aliabbasrizvi @haleybash-optimizely