Skip to content

Feature/bucketing #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 27, 2017
Merged

Feature/bucketing #154

merged 12 commits into from
Nov 27, 2017

Conversation

thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Nov 22, 2017 •
edited by kellyroach-optimizely
Loading

OASIS-1523 Bucketing IDs Feature Implementation

@kellyroach-optimizely
Copy link

GOALS:
*1 "./gradlew build" should pass.
*2 Make sure "bucketing_id" appears in user profile map .
*3 There should be a dictionary containing
"name": "optimizely_bucketing_id",
added to reported event.
*4 Convincingly run new tests
testBucketWithBucketingId
testBucketWithNullBucketingId

REVIEW:
*1 Early issues with "./gradlew build" addressed. PASSED
*2 Design doc also mentioned "$opt_bucketing_id" and we see
BUCKETING_ATTRIBUTE = "$opt_bucketing_id" has been added to DecisionService.java .
PASSED
*3 ATTRIBUTE_KEY_FOR_BUCKETING_ATTRIBUTE = "optimizely_bucketing_id"
along with believable if (attributeEntry.getKey() == DecisionService.BUCKETING_ATTRIBUTE) {...}
code added to EventBuilderV2.java PASSED
*4 Confirmed both new tests run and PASSED

kellyroach-optimizely
kellyroach-optimizely approved these changes Nov 22, 2017
View reviewed changes
Copy link

@kellyroach-optimizely kellyroach-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOALS/REVIEW comment added to P.R. You will need to resolve conflicts with master branch. Approved.

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 6bb9969 into master Nov 27, 2017
thomaszurkan-optimizely added a commit that referenced this pull request Jan 30, 2018
@thomaszurkan-optimizely
Feature/bucketing (#154)
e57e149 
* bucketing id implementation
* add a few more unit tests
* change bucket name
* added event builder code and tests after looking at php master bucketing_id changes
* cleanup from alda's comments
* update bucketingId javadoc and tests
* remove userId from bucketer method parameters since it is only used for logging
* update to fix FindBug warnings
@mikeproeng37 mikeproeng37 deleted the feature/bucketingId branch September 21, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kellyroach-optimizely kellyroach-optimizely kellyroach-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaszurkan-optimizely @kellyroach-optimizely