Skip to content

integrate coveralls #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 26, 2018
Merged

integrate coveralls #169

merged 11 commits into from
Feb 26, 2018

Conversation

wangjoshuah
Copy link
Contributor

No description provided.

@wangjoshuah
Copy link
Contributor Author

Integrate multi-project build of coveralls with jacoco from guide here
https://github.com/kt3k/coveralls-gradle-plugin#use-with-mutli-project-build

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's make sure and check how the gradle change affects android.

@wangjoshuah wangjoshuah merged commit 370fceb into master Feb 26, 2018
@wangjoshuah wangjoshuah deleted the josh.wang/integrate_coveralls branch February 26, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

@vraja2 vraja2 Awaiting requested review from vraja2

@kellyroach-optimizely kellyroach-optimizely Awaiting requested review from kellyroach-optimizely

1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangjoshuah @thomaszurkan-optimizely