fix(nullfilter): filters out attributes with null values #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 610
💛 - Coveralls |
msohailhussain
changed the title
mikeproeng37
suggested changes
Sep 7, 2018
| Map<String, String> actualValue = attributeCaptor.getValue(); | ||
| assertThat(actualValue, hasEntry(attribute.getKey(), null)); | ||
| assertNotSame(actualValue, hasEntry(attribute.getKey(), null)); | ||
| logbackVerifier.expectMessage(Level.WARN, "Attribute(s) ["+attribute.getKey()+"] not in the datafile or has NULL value."); |
There was a problem hiding this comment.
nit: spaces before and after the +
mikeproeng37
suggested changes
Sep 10, 2018
There was a problem hiding this comment.
I commented on the actual ticket, but we are changing this to filter out null attribute values from being sent to the log tier so it should be done here: https://github.com/optimizely/java-sdk/blob/master/core-api/src/main/java/com/optimizely/ab/event/internal/EventFactory.java#L170
|
@mikeng13 I made PR #214 so I think we can close this PR. |
|
@mikeng13 . I'm closing this PR since they are now addressing the issue in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.