Skip to content

change typedAudiences.conditions to be non-string encoded but still s… #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2018
Merged

change typedAudiences.conditions to be non-string encoded but still s… #229

merged 1 commit into from
Nov 2, 2018

Conversation

thomaszurkan-optimizely
Copy link
Contributor

…upport audience.conditions as a string

@coveralls
Copy link

coveralls commented Oct 31, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 718

  • 12 of 12 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.263%
Totals Coverage Status
Change from base Build 700: 0.02%
Covered Lines: 2494
Relevant Lines: 2794
💛 - Coveralls

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 6a0ace3 into master Nov 2, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the typedAudienceNotStringEncoded branch November 2, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganlinn loganlinn Awaiting requested review from loganlinn

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

@mjc1283 mjc1283 Awaiting requested review from mjc1283

1 more reviewer

@nchilada nchilada nchilada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaszurkan-optimizely @coveralls @nchilada