Skip to content

Adding missing unit tests related to notification listener #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

Thanks to @mikecdavis for pointing out missing coverage in our unit tests.

Added tests for classes:

  • DecisionNotification
  • FeatureTestSourceInfo
  • RolloutSourceInfo

Also renamed newFeatureVariableBuilder --> newFeatureVariableDecisionNotificationBuilder.

Was unsure if I should add more tests per builder in DecisionNotification.java. Feedback welcome on that.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 996

  • 10 of 19 (52.63%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 89.39%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-api/src/main/java/com/optimizely/ab/notification/DecisionNotification.java 9 18 50.0%
Totals Coverage Status
Change from base Build 987: -0.2%
Covered Lines: 2856
Relevant Lines: 3195

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 2, 2019

Pull Request Test Coverage Report for Build 1000

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 89.847%

Totals Coverage Status
Change from base Build 998: 0.06%
Covered Lines: 2929
Relevant Lines: 3260

💛 - Coveralls

Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ironically we lost coverage since you added those null checks. Up to you if you want to add coverage there.

@aliabbasrizvi aliabbasrizvi merged commit 9352ac4 into master May 2, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/add_more_tests branch May 2, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants