Rename UserExperimentRecord to UserProfile. #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraja2
suggested changes
Dec 6, 2016
| @@ -458,8 +458,8 @@ public Builder withErrorHandler(ErrorHandler errorHandler) { | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder withUserExperimentRecord(UserExperimentRecord userExperimentRecord) { | |||
| this.userExperimentRecord = userExperimentRecord; | |||
| public Builder withUserExperimentRecord(UserProfile userProfile) { | |||
| } | ||
|
|
||
| /** | ||
| * Gives implementations of {@link UserExperimentRecord} a chance to remove records | ||
| * Gives implementations of {@link UserProfile} a chance to remove records | ||
| * of experiments that are deleted or not running. | ||
| */ | ||
| public void cleanUserExperimentRecords() { |
| @@ -103,12 +103,12 @@ public void withDefaultErrorHandler() throws Exception { | |||
|
|
|||
| @Test | |||
| public void withUserExperimentRecord() throws Exception { | |||
| @@ -447,106 +447,106 @@ public void bucketUserNotInOverlappingGroupExperiment() throws Exception { | |||
|
|
|||
| /** | |||
| * Verify that {@link Bucketer#bucket(Experiment,String)} saves a variation of an experiment for a user | |||
| * when a {@link UserExperimentRecord} is present. | |||
| * when a {@link UserProfile} is present. | |||
| */ | |||
| @Test public void bucketUserSaveActivationWithUserExperimentRecord() throws Exception { | |||
| } | ||
|
|
||
| /** | ||
| * Verify that {@link Bucketer#bucket(Experiment,String)} logs correctly | ||
| * when a {@link UserExperimentRecord} is present and fails to save an activation. | ||
| * when a {@link UserProfile} is present and fails to save an activation. | ||
| */ | ||
| @Test public void bucketUserSaveActivationFailWithUserExperimentRecord() throws Exception { |
| @@ -562,16 +562,16 @@ public void nullUserExperimentRecordWhenCleaning() { | |||
|
|
|||
| /** | |||
| * Verify {@link Bucketer#cleanUserExperimentRecords()} handles a null returned from | |||
| @@ -586,19 +586,19 @@ public void nullUserExperimentRecords() { | |||
| @Test | |||
| public void cleanRemovesRecordsOfExperimentsThatNoLongerExist() { | |||
| @@ -608,19 +608,19 @@ public void cleanRemovesRecordsOfExperimentsThatNoLongerExist() { | |||
| @Test | |||
| public void cleanRemovesRecordsOfExperimentsThatAreNotRunning() { | |||
| * | ||
| * @param bucketValue the expected bucket value holder | ||
| * @return the mock bucket algorithm | ||
| */ | ||
| private Bucketer mockUserExperimentRecordAlgorithm(final AtomicInteger bucketValue, final UserExperimentRecord userExperimentRecord) { | ||
| return new Bucketer(validProjectConfigV2(), userExperimentRecord) { | ||
| private Bucketer mockUserExperimentRecordAlgorithm(final AtomicInteger bucketValue, final UserProfile userProfile) { |
|
LGTM |
vraja2
approved these changes
Dec 6, 2016
vraja2
pushed a commit
that referenced
this pull request
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@optimizely/fullstack-devs