Skip to content

docs: changed reference from the wrong classname to the correct one i… #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2020
Merged

docs: changed reference from the wrong classname to the correct one i… #388

merged 2 commits into from
Aug 21, 2020

Conversation

umermansoor
Copy link
Contributor

@umermansoor umermansoor commented Aug 3, 2020 •
edited
Loading

…n Javadocs

Summary

  • Fixed Javadocs in the OptimizelyFactory class that were referencing to (non-existent) OptimizelyClients

Why I changed it? Because it is confusing for users :)

Test plan

Issues

@umermansoor umermansoor requested a review from a team as a code owner August 3, 2020 16:27
@coveralls
Copy link

coveralls commented Aug 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1488

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.369%
Totals Coverage Status
Change from base Build 1486: 0.0%
Covered Lines: 4077
Relevant Lines: 4562
💛 - Coveralls

@umermansoor
Copy link
Contributor Author

Hi, is there an issue with the PR?

aliabbasrizvi
aliabbasrizvi approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this and taking care of signing the CLA.

@umermansoor
Copy link
Contributor Author

Thanks @aliabbasrizvi Looks like it is ready to be merged :)

This pull request can be automatically merged by project collaborators
Only those with write access to this repository can merge pull requests.

@aliabbasrizvi aliabbasrizvi merged commit 66d42c3 into optimizely:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@umermansoor umermansoor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umermansoor @coveralls @aliabbasrizvi