Skip to content

Feat: Added Semantic versioning invalid scenarios unit Tests. #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2020
Merged

Feat: Added Semantic versioning invalid scenarios unit Tests. #393

merged 2 commits into from
Aug 28, 2020

Conversation

mnoman09
Copy link
Contributor

Summary

  • contains unit tests of invalid scenarios in which semantic version should return null and throw exception.
  • added dot count function to to verify if the count of dot is smaller than prefixVersion count.

Test plan

Unit tests added and did Manual FSC testing

@mnoman09 mnoman09 requested a review from a team as a code owner August 26, 2020 12:03
@mnoman09 mnoman09 removed their assignment Aug 26, 2020
@coveralls
Copy link

coveralls commented Aug 26, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1502

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 89.559%
Totals Coverage Status
Change from base Build 1501: 0.06%
Covered Lines: 4100
Relevant Lines: 4578
💛 - Coveralls

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit d3dd94d into master Aug 28, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the mnoman/SemVerInvalidTests branch August 28, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🤖 16 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnoman09 @coveralls @thomaszurkan-optimizely @optimizely-codereview-bot @msohailhussain