Skip to content

Fix: Added JsonInclude as always when serializing on campaign and experiment id. #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 2, 2021
Merged

Fix: Added JsonInclude as always when serializing on campaign and experiment id. #422

merged 3 commits into from
Mar 2, 2021

Conversation

mnoman09
Copy link
Contributor

Summary

  • Added JsonInclude as always when serializing on campaign and experiment id.
  • This is to make sure that decision object contains campaign and experiment id even when null.
  • This change is just to pass the tests on FSC as while serialization of dispatched event rollout campaign id and experiment id was missing because they were null.

@mnoman09 mnoman09 requested a review from a team as a code owner February 12, 2021 13:04
@coveralls
Copy link

coveralls commented Feb 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1679

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.351%
Totals Coverage Status
Change from base Build 1678: 0.0%
Covered Lines: 4457
Relevant Lines: 4933
💛 - Coveralls

jaeopt
jaeopt approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 1ead293 into master Mar 2, 2021
@jaeopt jaeopt deleted the mnoman/campaignIdFix branch March 2, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @coveralls @jaeopt