Skip to content

fix(ats): convert graphQL query for fetchQualifiedSegments with vuid #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix(ats): convert graphQL query for fetchQualifiedSegments with vuid #504

merged 1 commit into from
Feb 10, 2023

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Feb 9, 2023

Summary

When vuid is used as userId, graphQL fetch segments api should be called with "vuid" as a query identifier.

Test plan

  • Unit test validating "vuid" as a query identifier.

Issues

@jaeopt jaeopt requested a review from a team as a code owner February 9, 2023 19:47
@jaeopt jaeopt removed their assignment Feb 9, 2023
@jaeopt jaeopt requested a review from mnoman09 February 9, 2023 19:49
mnoman09
mnoman09 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit c7f9099 into master Feb 10, 2023
@jaeopt jaeopt deleted the jae/vuid-fetch-segments branch February 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mnoman09 mnoman09 mnoman09 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🤖 4 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @mnoman09 @optimizely-codereview-bot