Skip to content

[FSSDK-9054] fix(odp): flush odp events instantly upon calling close #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

[FSSDK-9054] fix(odp): flush odp events instantly upon calling close #511

merged 2 commits into from
Apr 25, 2023

Conversation

mnoman09
Copy link
Contributor

Summary

  • Added shutdown signal instead of Boolean variable, because previously event queue was waiting for flushInterval to meet before shutting down.
  • Fixed unit test which was checking for flushing events upon calling stop.

Test plan

All tests should pass.

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner April 19, 2023 00:42
@mnoman09 mnoman09 removed their assignment Apr 19, 2023
jaeopt
jaeopt approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnoman09 mnoman09 merged commit 2022b49 into master Apr 25, 2023
@mnoman09 mnoman09 deleted the mnoman/FSSDK-9054-flush-on-close branch April 25, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @jaeopt @NomanShoaib