Skip to content

[FSSDK-9041] chore: upgrade dependency versions #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jun 2, 2023

Summary

Upgrade dependency versions to clear source clear warnings

  • gson: 2.8.6 -> 2.10.1
  • HttpClient: 4.5.13 -> 4.5.14
  • Jackson-annotations: 2.11.2 -> 2.15.2

Test plan

  • pass all existing tests

Issues

  • FSSDK-9041

@jaeopt jaeopt requested a review from a team as a code owner June 2, 2023 19:08
@jaeopt jaeopt removed their assignment Jun 2, 2023
@jaeopt jaeopt requested a review from mnoman09 June 2, 2023 21:18
Copy link

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small question/thought, but LGTM.

@@ -1 +0,0 @@
httpClientVersion = 4.5.13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking (perhaps automatic): Did you intend to remove (vs upgrade) this entry? Can we delete the file if it's going to be empty?

jsonVersion = 20190722
jsonSimpleVersion = 1.1.1
logbackVersion = 1.2.3
slf4jVersion = 1.7.30
httpClientVersion = 4.5.14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, maybe it was an upgrade and move 🤔

@jaeopt jaeopt closed this Jun 5, 2023
@jaeopt jaeopt reopened this Jun 5, 2023
@jaeopt jaeopt merged commit c60c9e6 into master Jun 5, 2023
@jaeopt jaeopt deleted the jae/dependencies branch June 5, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants