Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10095] fix events dropped on staled connections. #545

Merged
merged 6 commits into from
May 8, 2024
Merged

[FSSDK-10095] fix events dropped on staled connections. #545

merged 6 commits into from
May 8, 2024

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented May 7, 2024

Summary

Events can be discarded for staled connections with httpclient connection pooling.
This PR fixs it with -

  1. reduce the time for connection validation from 5 to 1sec.
  2. enable retries (x3) for event POST.

Test plan

  • new unit tests covering parameter configurations and retries

Issues

@jaeopt jaeopt requested a review from a team as a code owner May 7, 2024 18:56
@jaeopt jaeopt requested a review from muzahidul-opti May 7, 2024 18:56
@jaeopt jaeopt removed their assignment May 7, 2024
Mat001
Mat001 approved these changes May 7, 2024
View reviewed changes
Copy link

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit 71f9e75 into master May 8, 2024
17 checks passed
@jaeopt jaeopt deleted the jae/FSSDK-10095 branch May 8, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@pvcraven pvcraven pvcraven approved these changes

@muzahidul-opti muzahidul-opti Awaiting requested review from muzahidul-opti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaeopt @Mat001 @pvcraven