Skip to content

[FSSDK-11520] parse holdout section and update project config #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 31, 2025
Merged

[FSSDK-11520] parse holdout section and update project config #572

merged 19 commits into from
Jul 31, 2025

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Jul 22, 2025 •
edited
Loading

Summary

  • Parse holdout list
  • Add holdout config to handle global and local order
  • Updata datafile project config to handle holdout

Test plan

Issues

  • FSSDK-11520
  • FSSDK-11521

@muzahidul-opti muzahidul-opti changed the title [FSSDK-11520] parse HO section and update project config for HO [FSSDK-11520] parse holdout section and update project config Jul 23, 2025
@muzahidul-opti muzahidul-opti marked this pull request as ready for review July 23, 2025 12:15
@muzahidul-opti muzahidul-opti requested a review from jaeopt July 23, 2025 14:46
jaeopt
jaeopt requested changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of suggestions.

@muzahidul-opti muzahidul-opti requested a review from jaeopt July 30, 2025 14:10
jaeopt
jaeopt approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 05f922d into master Jul 31, 2025
16 of 17 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/FSSDK-11538 branch July 31, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt