Partition Bucketer.bucket() #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is covered by `getVariationForcedVariationPrecedesAudienceEval` in OptimizelyTestV2.java and OptimizelyTestV3.java
1) User is whitelisted -> return whitelisted variation 2) Whitelist mapping is incorrect -> return null 3) User is not whitelisted -> return null
Check getStoredVariation returns user Profile lookup values correctly. Remove test for continuation since that is in OptimizelyTestV2-V3.java Bucketer.bucket should not call lookup
…t.java to `trackDoesNotSendEventWhenUserDoesNotSatisfyAudiences` in OptimizelyTestV2.java and OptimizelyTestV3.java
from ProjectValidationutilsTestV2.java to `getVariationEvaluatesUserProfileBeforeAudienceTargeting` in OptimizelyTestV2.java and OptimizelyTestV3.java
…sting precedes user profile check
vraja2
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.