Skip to content

change anonymizeIP to NSNumber* optional #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

change anonymizeIP to NSNumber* optional #250

wants to merge 1 commit into from

Conversation

thomaszurkan-optimizely
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.403% when pulling 0c50441 on fix/allowV2Datafile into 82cc544 on master.

1 similar comment
@coveralls
Copy link

coveralls commented May 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.403% when pulling 0c50441 on fix/allowV2Datafile into 82cc544 on master.

aliabbasrizvi
aliabbasrizvi suggested changes May 17, 2018
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a unit test checking initialization and confirming this is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyroach-optimizely kellyroach-optimizely Awaiting requested review from kellyroach-optimizely

1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaszurkan-optimizely @coveralls @aliabbasrizvi