Skip to content

chore: fix xcode 12 build failure #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

chore: fix xcode 12 build failure #457

merged 1 commit into from
Oct 6, 2020

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Oct 6, 2020

Summary

  • Xcode 12 fails building SDK modules with CocoaPods (fails at linking)
  • Explicitly add secondary dependencies into podspec

@jaeopt jaeopt requested a review from a team as a code owner October 6, 2020 21:07
@jaeopt jaeopt removed their assignment Oct 6, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.138% when pulling 855b35b on jae/xcode12-build into e5c3aea on master.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 5db54ae into master Oct 6, 2020
@jaeopt jaeopt deleted the jae/xcode12-build branch October 6, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @coveralls @thomaszurkan-optimizely