-
Notifications
You must be signed in to change notification settings - Fork 4
[FSSDK-11875] chore: add support for android 15 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Bump compile SDK version to 35 and build tools version to "35.0.0" - Update target SDK version to 35 - Add namespace 'com.optimizely.optimizely_flutter_sdk' - Enable buildConfig feature - Update kotlin-stdlib-jdk7 to version 2.1.0 - Update jackson-databind to version 2.17.2 - Set minSdkVersion and targetSdkVersion to 35 for example app - Update distributionUrl in gradle-wrapper.properties to Gradle 8.10.2 - Update android plugin version to 8.7.0 and kotlin-android version to 2.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's test with different version numbers in app.
android/build.gradle
Outdated
build_tools_version = "35.0.0" | ||
min_sdk_version = 21 | ||
target_sdk_version = 29 | ||
target_sdk_version = 35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand we do not need this target_sdk_version in flutter sdk. Can we drop it so we can live longer when google increase the target_sdk_version requirement to 36 next year?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to set target_sdk_version
. As per documentation it will be set to 21.
"If not set, the default value equals that given to minSdkVersion"
I think, there is no way for future proof.
- Update compile SDK version to 36 and build tools version to "36.0.0" - Change min SDK version to 21 and target SDK version to 36 in the Android build configuration - Update compile SDK version to 36 and target SDK version to 36 in the example app build.gradle file
Summary
Update target SDK version to 35
Update distributionUrl in gradle-wrapper.properties to Gradle 8.10.2
Update android plugin version to 8.7.0 and kotlin-android version to 2.1.0
New requirement by google https://developer.android.com/google/play/requirements/target-sdk
Test plan
Issues