Skip to content

feat(DecisionListener): Adds feature variables decision listener. #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 2, 2019
Merged

feat(DecisionListener): Adds feature variables decision listener. #162

merged 6 commits into from
Apr 2, 2019

Conversation

rashidsp
Copy link
Contributor

Summary

Implemented onDecisionListener in get feature variable APIs.

Test plan

Unit tests for DecisionListener

Issues

  • OASIS-4234

@coveralls
Copy link

coveralls commented Mar 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 98.159% when pulling 3c7464f on rashid/decision-listener-feature-variables into 4a68390 on master.

@msohailhussain msohailhussain requested a review from a team March 29, 2019 18:24
aliabbasrizvi
aliabbasrizvi approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliabbasrizvi aliabbasrizvi merged commit e164ef3 into master Apr 2, 2019
@aliabbasrizvi aliabbasrizvi deleted the rashid/decision-listener-feature-variables branch April 2, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rashidsp @coveralls @aliabbasrizvi